Skip to content

feat: Implement HealthCheck functionality#185

Merged
dipasqualew merged 2 commits intomasterfrom
ENG-210-implement-healthcheck-functionality
Feb 10, 2021
Merged

feat: Implement HealthCheck functionality#185
dipasqualew merged 2 commits intomasterfrom
ENG-210-implement-healthcheck-functionality

Conversation

@dipasqualew
Copy link
Copy Markdown
Contributor

@dipasqualew dipasqualew commented Feb 10, 2021

It is a common task to health check an application at start up and force an early failure. The health check logic should be based on LambdaWrapper and extended in each application.

See:

It is a common task to health check an application at start up and force an early failure. The health check logic should be based on LambdaWrapper and extended in each application.

See:
- [ENG-210]
@dipasqualew dipasqualew self-assigned this Feb 10, 2021
lebaz20
lebaz20 previously approved these changes Feb 10, 2021
});
});

[400, 401, 403, 404, 409, 499, 500, 501, 502, 503, 504, 'Dante Alighieri'].forEach((statusCode) => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice touch :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to spread Dante Alighieri everywhere in our test cases! 😄

Comment thread src/Service/BaseConfig.service.js Outdated
Co-authored-by: Mohamed Labib <lebaz20@users.noreply.github.com>
@dipasqualew dipasqualew merged commit 014b2b8 into master Feb 10, 2021
@dipasqualew dipasqualew deleted the ENG-210-implement-healthcheck-functionality branch February 10, 2021 14:23
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants